docs: clarify ServiceMonitor and PrometheusRule defaults and alternatives#309
docs: clarify ServiceMonitor and PrometheusRule defaults and alternatives#309
Conversation
…ives Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 09f5b3d5c6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| existingSecret: "" | ||
|
|
||
| # @section Database initialization parameters | ||
| dbInit: |
There was a problem hiding this comment.
This change adds a dbInit section that claims to enable a pre-install database initialization Job, but the chart has no template path that consumes .Values.dbInit (I checked deploy/helm/codex-lb/templates/**). In practice, dbInit.enabled: true is a no-op, so operators can believe DB/users were provisioned when nothing ran. Please either include the actual hook/job implementation in the same change or defer this values block until that functionality exists.
Useful? React with 👍 / 👎.
|
Consolidating into 2 PRs: chart features + docs |
1 participant
Summary
Motivation
Users deploying with Prometheus (but not Prometheus Operator) don't know how to scrape codex-lb metrics. Users with Prometheus Operator don't know what alerts are available.